Closed
Conversation
nodejs-github-bot
added
dont-land-on-v6.x
http2
Member
Author
Member
|
@nodejs/http2 |
Member
Author
cjihrig
approved these changes
Sep 2, 2018
| * Version number of the nghttp2 library release | ||
| */ | ||
| #define NGHTTP2_VERSION "1.32.0" | ||
| #define NGHTTP2_VERSION "1.33.0-DEV" |
Contributor
There was a problem hiding this comment.
Should we be moving to a dev version? Or is this maybe a mistake on their end (based on the linked GitHub release)?
Member
Author
There was a problem hiding this comment.
I think this is a mistake by me, not having run configure in the nghttp2 checkout before copying the files. Thanks for catching!
Contributor
|
Landed in e007166. |
danbev
pushed a commit
that referenced
this pull request
Sep 5, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 PR-URL: #22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 5, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 PR-URL: #22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 PR-URL: #22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 3, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 PR-URL: nodejs#22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 PR-URL: nodejs#22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0 Backport-PR-URL: #22850 PR-URL: #22649 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes