build: use npm ci

[refack]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

• Follow up to [WIP] tools: s/npm install/npm ci #21538
• In general npm ci is faster and more intune with "black box use" of the packaged tools.
• Until Produce HTML documentation using unified/remark/rehype #21490 we floated patches on tools/doc/node_modules so we could use the npm ci which completely replaces node_modules
• H/T: @MylesBorins @Trott @rubys

Ref: #21802
Ref: #21490

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/592/pipeline

[refack]

/CC @nodejs/build-files @nodejs/documentation

[refack]

CI: https://ci.nodejs.org/job/node-test-commit/20679/

[Trott]

Change LGTM. (Avoiding official sign-off because I don't know all the details of how some of this stuff is invoked as well as others know it, and this already has two sign-offs, so it doesn't need mine.)

meant to leave a comment...

[rubys]

Meta: just so you know what you are getting with my approval. Essentially, it means that I'm saying "it looks plausible to me that it would work", and "should it break, I will help fix it".

I've been programming continuously since the mid 70s, so I have accumulated a working knowledge of batch files, make files, C, ES5, and the like. That doesn't mean that I have a deep understanding of npm, gyp, acorn, node's repl, etc. What you have seen there is only evidence that I'm a fast learner.

[refack]

Meta: just so you know what you are getting with my approval. Essentially, it means that I'm saying "it looks plausible to me that it would work", and "should it break, I will help fix it".

Ditto 😄
There is definite emergent complexity in our build scripts, one that only empirical experiments can uncover.

[joyeecheung]

LGTM.

(On a side note, I think we should also use --ignore-scripts in the installation commands..)

[refack]

(On a side note, I think we should also use --ignore-scripts in the installation commands..)

I'm not sure about that... Especially since node-gyp build is triggered as the default install script... I trust @zkat that npm ci was optimally designed.

Anyway I leave that to a future PR.

[refack]

linux/ubuntu1404 fail is #20628

[refack]

Reresume CI: https://ci.nodejs.org/job/node-test-commit/20822/

[refack]

Landed in d320511

[addaleax]

$ make format-cpp-build
cd tools/clang-format && if [ -x /home/xxxx/src/node/master/./node ] && [ -e /home/xxxx/src/node/master/./node ]; then /home/xxxx/src/node/master/./node /home/xxxx/src/node/master/./deps/npm/bin/npm-cli.js ci; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` /home/xxxx/src/node/master/./deps/npm/bin/npm-cli.js ci; else echo "No available node, cannot run \"node /home/xxxx/src/node/master/./deps/npm/bin/npm-cli.js ci\""; exit 1; fi;
npm ERR! cipm can only install packages with an existing package-lock.json or npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or later to generate it, then try again.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/xxxx/.npm/_logs/2018-08-23T14_41_43_532Z-debug.log
Makefile:1182: recipe for target 'format-cpp-build' failed
make: *** [format-cpp-build] Error 1

🙁