[v8.x backport] doc: fix/add link to Android info#22386
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:v8.x-stagingfrom
vsemozhetbyt:backport-19004-to-v8.x
Closed
[v8.x backport] doc: fix/add link to Android info#22386vsemozhetbyt wants to merge 1 commit intonodejs:v8.x-stagingfrom vsemozhetbyt:backport-19004-to-v8.x
vsemozhetbyt wants to merge 1 commit intonodejs:v8.x-stagingfrom
vsemozhetbyt:backport-19004-to-v8.x
Conversation
We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing. This PR makes both notes link to dedicated Android part of BUILDING.md. PR-URL: #19004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
3 tasks
jasnell
approved these changes
Aug 18, 2018
vsemozhetbyt
added
the
author ready
cjihrig
approved these changes
Aug 18, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing. This PR makes both notes link to dedicated Android part of BUILDING.md. Backport-PR-URL: #22386 PR-URL: #19004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport of #19004