test: rename some disturbing allegories#22307
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:rename-disturbing
Closed
test: rename some disturbing allegories#22307vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:rename-disturbing
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:rename-disturbing
Conversation
Contributor
Author
danbev
approved these changes
Aug 14, 2018
cjihrig
approved these changes
Aug 14, 2018
maclover7
approved these changes
Aug 14, 2018
Contributor
Author
Contributor
Author
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
benjamingr
approved these changes
Aug 14, 2018
Contributor
Author
|
Concerning repeated fails: #22308 |
refack
approved these changes
Aug 14, 2018
Contributor
|
Rest of fails are |
refack
added
the
author ready
Contributor
|
@vsemozhetbyt I would rename the commit to something more generic, like |
vsemozhetbyt
added
the
fast-track
Contributor
Author
|
Landed in 682f9b4 with more generic commit name. |
vsemozhetbyt
added a commit
that referenced
this pull request
Aug 14, 2018
PR-URL: #22307 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
PR-URL: #22307 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22307 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis somehow hit me in #22303, so I thought we could do the same we had done for the
child_processdoc. I've renamed only some cases where renaming impact was not so big.