doc: list encodings supported by buffer.transcode#22263
doc: list encodings supported by buffer.transcode#22263jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
jasnell
added
buffer
nodejs-github-bot
added
buffer
jasnell
added
the
author ready
Trott
removed
the
author ready
| conversion from `fromEnc` to `toEnc` is not permitted. | ||
|
|
||
| Encodings supported by `buffer.transcode()` include: `'ascii'`, `'utf8'`, | ||
| `'utf16le'`, `'ucs2'`, `'latin1'`, and `'binary'`. |
There was a problem hiding this comment.
No. 'hex' is not supported
doc/api/buffer.md
Outdated
| Throws if the `fromEnc` or `toEnc` specify invalid character encodings or if | ||
| conversion from `fromEnc` to `toEnc` is not permitted. | ||
|
|
||
| Encodings supported by `buffer.transcode()` include: `'ascii'`, `'utf8'`, |
There was a problem hiding this comment.
include -> are assuming the list is supposed to be a complete list of supported encodings.
There was a problem hiding this comment.
Feel free to make whatever editorial changes you'd like
There was a problem hiding this comment.
Wanted to confirm the list is supposed to be complete before doing it. I'll take that as a "yes, it's a complete list" and make the change now. 👍
|
@nodejs/documentation Not sure if there's a desired formatting standard for "string values permitted for this argument must be from this small set". I don't think we have one, so I'm fine with this the way it is. Regardless, PTAL. |
|
@nodejs/buffer |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
|
Landed in a5b3c15 (fast tracked with approval) |
Fixes: nodejs/node#15632 PR-URL: nodejs/node#22263 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
7 participants
Fixes: #15632
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes