inspector: unmark tests as flaky#22253
Merged
eugeneo merged 0 commit intonodejs:masterfrom Aug 13, 2018
eugeneo:tests_not_flaky
Merged
inspector: unmark tests as flaky#22253eugeneo merged 0 commit intonodejs:masterfrom eugeneo:tests_not_flaky
eugeneo merged 0 commit intonodejs:masterfrom
eugeneo:tests_not_flaky
Conversation
cjihrig
approved these changes
Aug 10, 2018
jasnell
approved these changes
Aug 10, 2018
alexkozy
approved these changes
Aug 10, 2018
TimothyGu
approved these changes
Aug 11, 2018
Member
Trott
added
author ready
trivikr
approved these changes
Aug 12, 2018
Member
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16377/ |
lpinca
approved these changes
Aug 12, 2018
rvagg
pushed a commit
that referenced
this pull request
Aug 15, 2018
PR-URL: #22253 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22253 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNo failures across 1000 runs (red bots seem to be unsupported): https://ci.nodejs.org/job/node-stress-single-test/1979/