Closed
Conversation
addaleax
approved these changes
Aug 10, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I think you want a space after the email address :)
richardlau
approved these changes
Aug 10, 2018
refack
approved these changes
Aug 10, 2018
Member
Author
|
New CI run after addressing changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/492/ |
jasnell
approved these changes
Aug 10, 2018
vsemozhetbyt
approved these changes
Aug 10, 2018
gdams
added
the
author ready
Trott
approved these changes
Aug 10, 2018
richardlau
added
the
notable-change
Member
Author
|
landed as: 91e897a |
gdams
pushed a commit
that referenced
this pull request
Aug 10, 2018
PR-URL: #22236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
PR-URL: #22236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22236 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes