Add multiple issue templates by tniessen · Pull Request #22215 · nodejs/node

tniessen · 2018-08-09T15:09:17Z

An initial attempt at using the new issue template tool provided by GitHub. I created the commits using the GitHub template wizard, I can take care of fixing the commit message if we decide to land this.

Looking forward to feedback and suggestions!

Fixes: #21812

nodejs-github-bot · 2018-08-09T15:09:26Z

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/478/pipeline

mscdex · 2018-08-09T15:59:57Z

Are we sure links will render correctly with the exclamation point at the end of them?

tniessen · 2018-08-09T16:10:24Z

@mscdex They do in the GitHub markdown editor.

lundibundi · 2018-08-09T20:27:20Z

.github/ISSUE_TEMPLATE/---feature-request.md

Please describe what is the problem you are trying to solve? Though not a native speaker.

I think line 13 is sufficiently clear that line 14 isn't really necessary.

How about: Please describe the problem you are trying to solve.?

lundibundi · 2018-08-09T20:27:34Z

.github/ISSUE_TEMPLATE/---feature-request.md

Please describe what do you want to happen?

Maybe Please describe the desired behavior.?

vsemozhetbyt · 2018-08-09T23:14:39Z

.github/ISSUE_TEMPLATE/---feature-request.md

sugesting -> suggesting

sagirk

LGTM! 🎉

A few minor nits below:

sagirk · 2018-08-10T04:36:20Z

.github/ISSUE_TEMPLATE/---bug-report.md

nit: able. -> able to. + same throughout

nit: able. -> able to. + same throughout

I'm mildly opposed to adding to.

If ending with able seems awkward or unclear, maybe as much as you're able -> as much as you can?

+1 on as much as you can. Otherwise I would also stumble upon the sentence.

sagirk · 2018-08-10T04:37:16Z

.github/ISSUE_TEMPLATE/---bug-report.md

nit: specify affected -> specify the affected

sagirk · 2018-08-10T04:38:40Z

.github/ISSUE_TEMPLATE/---bug-report.md

nit: provide code -> provide the code

I'm mildly opposed to this nit too. Just provide code.

sagirk · 2018-08-10T04:40:49Z

.github/ISSUE_TEMPLATE/---bug-report.md

nit: Enter your issue details -> Please provide more details

tniessen · 2018-08-10T09:31:28Z

@sagirk All of the nits you listed already existed in the old issue template. Can someone from nodejs/collaborators confirm that these should be changed?

Trott

LGTM. I'm sure we'll want to iterate on these as we see how they work.

Fixes: nodejs#21812

tniessen · 2018-08-10T16:09:50Z

Thanks, @Trott. The filenames were generated by the GitHub wizard, I assume it is safe to change them, but I have no idea whether that would interfere with GitHub tools later on.

devsnek · 2018-08-10T16:29:48Z

@tniessen you can replace the first two dashes with a number e.g. 01-bug-report.mjd and 02-help-me.md so that they appear in a certain order. it's not required of course.

BridgeAR

LGTM but it would be nice to have the nit addressed.

BridgeAR · 2018-08-10T16:35:55Z

.github/ISSUE_TEMPLATE/---bug-report.md

+1 on as much as you can. Otherwise I would also stumble upon the sentence.

BridgeAR · 2018-08-10T16:37:42Z

.github/ISSUE_TEMPLATE/---need-help-with-node-js-.md

+---
+
+If you have a question about Node.js that is not a bug report or feature
+request, please post it in https://github.com/nodejs/help!


Maybe also add in this and the node.js org one that this will be closed if opened?

BridgeAR

Still LGTM

Fixes: #21812 PR-URL: #22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2018-08-12T17:20:19Z

Landed in 3ce9275

Fixes: #21812 PR-URL: #22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: nodejs/node#21812 PR-URL: nodejs/node#22215 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 9, 2018

lundibundi reviewed Aug 9, 2018

View reviewed changes

vsemozhetbyt reviewed Aug 9, 2018

View reviewed changes

.github/ISSUE_TEMPLATE/---feature-request.md Outdated

Copy link

Contributor

vsemozhetbyt Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sugesting -> suggesting

sagirk approved these changes Aug 10, 2018

View reviewed changes

Trott approved these changes Aug 10, 2018

View reviewed changes

doc: add multiple issue templates fr GitHub

166a1dc

Fixes: nodejs#21812

tniessen force-pushed the add-multiple-issue-templates branch from 38fa282 to 166a1dc Compare August 10, 2018 16:04

Address sagirk's comments

6c89ac9

devsnek approved these changes Aug 10, 2018

View reviewed changes

BridgeAR approved these changes Aug 10, 2018

View reviewed changes

tniessen added 2 commits August 10, 2018 18:47

Address BridgeAR's nits

e456e4b

Rename issue templates

ae8c26b

BridgeAR approved these changes Aug 10, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2018

gdams approved these changes Aug 10, 2018

View reviewed changes

trivikr approved these changes Aug 12, 2018

View reviewed changes

jasnell approved these changes Aug 12, 2018

View reviewed changes

jasnell closed this Aug 12, 2018

rvagg mentioned this pull request Aug 13, 2018

Release proposal: v10.9.0 #22295

Merged

beevelop mentioned this pull request Aug 16, 2018

2018-08-15 Version 10.9.0 (Current) @rvagg beevelop/docker-android-nodejs#230

Closed

tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018

Uh oh!

Conversation

tniessen commented Aug 9, 2018

Uh oh!

nodejs-github-bot commented Aug 9, 2018

Uh oh!

mscdex commented Aug 9, 2018

Uh oh!

tniessen commented Aug 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagirk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott Aug 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott Aug 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tniessen commented Aug 10, 2018

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

tniessen commented Aug 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devsnek commented Aug 10, 2018

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Aug 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Trott Aug 10, 2018 •

edited

Loading

Trott Aug 10, 2018 •

edited

Loading

tniessen commented Aug 10, 2018 •

edited

Loading