test: update certificates and private keys by indutny · Pull Request #22184 · nodejs/node

indutny · 2018-08-07T23:42:34Z

The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.

Fix: #22182

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 9999 days for all of them to prevent this from happening again in near future. Fix: #22182

nodejs-github-bot · 2018-08-07T23:42:36Z

@indutny build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/455/pipeline

indutny · 2018-08-07T23:42:48Z

cc @MylesBorins @nodejs/crypto @bnoordhuis

indutny · 2018-08-07T23:43:37Z

test/fixtures/keys/Makefile

 ca3-csr.pem: ca3.cnf ca3-key.pem
 	openssl req -new \
 		-extensions v3_ca \
+		-days 9999 \


Gosh, this slipped my quick review. It isn't really necessary, since the days are set in ca3.cnf.

Should we remove it or just leave it?

MylesBorins · 2018-08-07T23:49:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16262/

MylesBorins · 2018-08-07T23:58:50Z

@indutny no bueno

test.parallel/test-crypto-sign-verify
test.parallel/test-tls-cert-chains-concat
test.parallel/test-tls-cert-chains-in-ca
test.parallel/test-tls-multi-pfx
test.parallel/test-tls-peer-certificate

all failing

https://ci.nodejs.org/job/node-test-commit-linux/20522/nodes=alpine-latest-x64/

indutny · 2018-08-08T00:23:00Z

Should be fixed now.

MylesBorins · 2018-08-08T00:42:33Z

one more ci: https://ci.nodejs.org/job/node-test-pull-request/16263/

MylesBorins

LGTM

we should fast track this as it is breaking lots of things

MylesBorins

😅

jasnell · 2018-08-08T01:43:58Z

I wonder if we shouldn't look at potentially dynamically generating these every so often

MylesBorins · 2018-08-08T01:45:36Z

one last ci with sn extra 9... giving us 273 years to figure this out instead of 27

https://ci.nodejs.org/job/node-test-pull-request/16264/

jasnell · 2018-08-08T01:47:33Z

Ah yes, good ole Node.js 557.0.0

MylesBorins · 2018-08-08T01:58:08Z

@indutny still getting failures on arm

https://ci.nodejs.org/job/node-test-binary-arm/2608/RUN_SUBSET=5,label=pi3-docker/console

indutny · 2018-08-08T01:59:22Z

21:53:31     AssertionError [ERR_ASSERTION]: 5 2 agent3 rejected, but should NOT have been
21:53:31         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-tls-server-verify.js:232:14)
21:53:31         at ChildProcess.emit (events.js:182:13)
21:53:31         at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

MylesBorins · 2018-08-08T03:00:23Z

@mhdawson and I dug in a bunch and it seems like the failures on arm are infra related... potentially during setup

@rvagg can you dig into this?

One more ci: https://ci.nodejs.org/job/node-test-pull-request/16265/

landing if green

Trott

Rubber-stamp LGTM if CI is green. +1 to fast-tracking

Trott · 2018-08-08T04:24:36Z

parallel/test-tls-server-verify still failing on Raspberry Pi...

MylesBorins · 2018-08-08T04:25:22Z

oops... I did the status file wrong

re-running arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/2721/

rvagg · 2018-08-08T04:47:52Z

Diagnosis & fix nodejs/build#1432
New CI run @ https://ci.nodejs.org/job/node-test-binary-arm/2612/ looking green.

The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

Trott · 2018-08-08T05:25:11Z

Custom suites failed to git clone again. Re-running (again): https://ci.nodejs.org/job/node-test-commit-custom-suites/524/ (Not that it's relevant, since in node-daily-master, I'm pretty sure it only runs the internet suite.)

MylesBorins · 2018-08-08T05:25:33Z

Backporting to all staging branches

v11.x-staging 6efbe1a
v10.x-staging: a6b9ee9
v8.x-staging: 50ccfec
v6.x-staging: 14b46d0

Trott · 2018-08-08T05:27:32Z

Unrelated flaky on LinuxONE, re-running: https://ci.nodejs.org/job/node-test-commit-linuxone/3652/

Trott · 2018-08-08T05:27:46Z

Custom suites passed.

Trott · 2018-08-08T05:33:28Z

LinuxONE passed.

Trott · 2018-08-08T05:43:12Z

Argh, the --worker custom suite run also failed. Re-run: https://ci.nodejs.org/job/node-test-commit-custom-suites/528/

Trott · 2018-08-08T05:55:09Z

--worker custom suite re-run passed.

The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: #22184 Fixes: #22182 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

The certificates in test fixtures were set to expire in 999 days since they were generated. That time has passed, and they have to be reissued. Bump expiration time to 99999 days for all of them to prevent this from happening again in near future. PR-URL: nodejs/node#22184 Fixes: nodejs/node#22182 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 7, 2018

indutny commented Aug 7, 2018

View reviewed changes

indutny added 3 commits August 7, 2018 19:59

fixup

b012905

test: update serial numbers and add missing file

1394b0e

test: fix crypto-sign-verify

f1b3db1

MylesBorins suggested changes Aug 8, 2018

View reviewed changes

MylesBorins approved these changes Aug 8, 2018

View reviewed changes

devsnek approved these changes Aug 8, 2018

View reviewed changes

devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 8, 2018

fixup: moar 9s

c2a2e75

jasnell approved these changes Aug 8, 2018

View reviewed changes

Trott approved these changes Aug 8, 2018

View reviewed changes

MylesBorins force-pushed the fix/ci-certs branch from d82759a to 3e39945 Compare August 8, 2018 04:24

rvagg mentioned this pull request Aug 8, 2018

Incident: Jenkins misconfiguration for arm-fanned nodejs/build#1432

Closed

Trott mentioned this pull request Aug 8, 2018

doc: replace _WG_ with _team_ #22183

Closed

2 tasks

MylesBorins deleted the fix/ci-certs branch August 8, 2018 14:30

rvagg mentioned this pull request Aug 13, 2018

Release proposal: v10.9.0 #22295

Merged

MylesBorins mentioned this pull request Aug 17, 2018

v8.12.0 proposal #21593

Merged

Uh oh!

Conversation

indutny commented Aug 7, 2018 • edited by MylesBorins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Aug 7, 2018

Uh oh!

indutny commented Aug 7, 2018

Uh oh!

indutny Aug 7, 2018

Choose a reason for hiding this comment

Uh oh!

MylesBorins Aug 7, 2018

Choose a reason for hiding this comment

Uh oh!

indutny Aug 7, 2018

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Aug 7, 2018

Uh oh!

MylesBorins commented Aug 7, 2018

Uh oh!

indutny commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018

Uh oh!

indutny commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018

Uh oh!

rvagg commented Aug 8, 2018

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

MylesBorins commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

Trott commented Aug 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

indutny commented Aug 7, 2018 •

edited by MylesBorins

Loading

MylesBorins commented Aug 8, 2018 •

edited

Loading

MylesBorins commented Aug 8, 2018 •

edited

Loading