test: Remove third argument from assert.strictEqual()#22051
Closed
rishabhptr wants to merge 1 commit intonodejs:masterfrom
Closed
test: Remove third argument from assert.strictEqual()#22051rishabhptr wants to merge 1 commit intonodejs:masterfrom
rishabhptr wants to merge 1 commit intonodejs:masterfrom
Conversation
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual().
Trott
approved these changes
Aug 1, 2018
Member
apapirovski
approved these changes
Aug 1, 2018
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
LGTM but do the comments actually help? I would argue we should remove them too.
jasnell
approved these changes
Aug 1, 2018
trivikr
approved these changes
Aug 1, 2018
cjihrig
approved these changes
Aug 1, 2018
maclover7
approved these changes
Aug 1, 2018
lpinca
approved these changes
Aug 1, 2018
BridgeAR
approved these changes
Aug 1, 2018
BridgeAR
added
fast-track
Member
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16142/ (edit @maclover7: ✔️) |
Contributor
|
Landed in 8d15f69, congrats on your first pull request to Node.js!! ❤️ 💚 💙 💛 💜 |
targos
pushed a commit
that referenced
this pull request
Aug 4, 2018
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual(). PR-URL: #22051 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In file test/parallel/test-stream-transform-final.js the ten calls to
assert.strictEqual() use a string literal as third argument. When
a AssertionError occurs, it reports the string literal and not the
first two arguments, so the third agrument is removed and made a
comment just above the call to assert.strictEqual().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes