dgram: deprecate all previous private APIs#22011
Conversation
cjihrig
added
the
semver-major
nodejs-github-bot
added
the
dgram
doc/api/deprecations.md
Outdated
There was a problem hiding this comment.
Nit: `dgram` API -> `dgram` module?
There was a problem hiding this comment.
Nit: remove "a number of" or even "a number of underscored"?
There was a problem hiding this comment.
May be the below one :
The
dgrammodule previously contained several APIs that were never meant to be accessed outside node core. These APIs include :
?
There was a problem hiding this comment.
The
dgrammodule previously contained several APIs that were never meant to be accessed outside node core. These APIs include :
@antsmartian That seems better to me, but a few nits:
-
node core->Node.js core(The project is always referred to asNode.js. The executable isnode.) -
Maybe get rid of "These APIs include" because that suggests it's an incomplete list. Just put a colon after
Node.js coreand list the functions there?
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
+1 on this change - given CITGM and the usual.
PR-URL: nodejs#22011 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
11 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes