src: clean up PackageConfig pseudo-boolean fields#21987
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: clean up PackageConfig pseudo-boolean fields#21987addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Jul 27, 2018
TimothyGu
approved these changes
Jul 28, 2018
cjihrig
approved these changes
Jul 28, 2018
BridgeAR
approved these changes
Jul 29, 2018
Member
Author
addaleax
added
the
author ready
Member
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16191/ |
Member
|
why are these enums at all |
Member
Author
|
@devsnek Some C++ programmers (including me) feel that using 2-valued enums over boolean can be valuable due to the improved type safety. |
Member
Author
|
Landed in a196aa2 |
addaleax
added a commit
that referenced
this pull request
Aug 5, 2018
PR-URL: #21987 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Aug 6, 2018
PR-URL: #21987 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes