doc: update and improve the release guide#21868
Closed
targos wants to merge 3 commits intonodejs:masterfrom
Closed
doc: update and improve the release guide#21868targos wants to merge 3 commits intonodejs:masterfrom
targos wants to merge 3 commits intonodejs:masterfrom
Conversation
addaleax
approved these changes
Jul 18, 2018
jasnell
approved these changes
Jul 18, 2018
maclover7
approved these changes
Jul 18, 2018
Contributor
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
Two small comments, other than that LGTM
doc/releases.md
Outdated
| omitted from a commit, the commit will show up because it's unsure if it's a | ||
| duplicate or not. | ||
|
|
||
| For a list of commits that could be landed in a patch release on v10.x: |
doc/releases.md
Outdated
|
|
||
| If the staging branch is not up to date relative to `master`, bring the | ||
| appropriate commits into it. To determine the relevant commits, use | ||
| [`branch-diff`](https://github.com/rvagg/branch-diff). The tool is available on |
Contributor
There was a problem hiding this comment.
micronit: branch-diff now lives at https://github.com/nodejs/branch-diff
cjihrig
approved these changes
Jul 19, 2018
lpinca
approved these changes
Jul 19, 2018
targos
added a commit
to targos/node
that referenced
this pull request
Jul 20, 2018
PR-URL: nodejs#21868 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in 1ffd353 |
targos
added a commit
that referenced
this pull request
Jul 20, 2018
PR-URL: #21868 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my experience with the latest releases, here is my contribution to the doc :)
@nodejs/releasers
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes