src: use offset calc. instead of req->data in node_file#21839
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: use offset calc. instead of req->data in node_file#21839addaleax wants to merge 1 commit intonodejs:masterfrom
req->data in node_file#21839addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
A small refactor – this removes one layer of pointer indirection. (The performance gain is likely negligible, the main point here being that this encapsulates libuv request management a bit more.)
nodejs-github-bot
added
c++
eugeneo
approved these changes
Jul 16, 2018
cjihrig
approved these changes
Jul 17, 2018
Member
Author
TimothyGu
approved these changes
Jul 17, 2018
devsnek
approved these changes
Jul 17, 2018
jasnell
approved these changes
Jul 17, 2018
tniessen
approved these changes
Jul 18, 2018
Member
Author
|
FreeBSD re-build: https://ci.nodejs.org/job/node-test-commit-freebsd/19088/ |
addaleax
added
the
author ready
maclover7
approved these changes
Jul 18, 2018
4 tasks
Member
Author
|
Landed in 2d32a7e |
addaleax
added a commit
that referenced
this pull request
Jul 19, 2018
A small refactor – this removes one layer of pointer indirection. (The performance gain is likely negligible, the main point here being that this encapsulates libuv request management a bit more.) PR-URL: #21839 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2018
A small refactor – this removes one layer of pointer indirection. (The performance gain is likely negligible, the main point here being that this encapsulates libuv request management a bit more.) PR-URL: #21839 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This was referenced Aug 1, 2018
This was referenced Jun 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small refactor – this removes one layer of pointer indirection.
(The performance gain is likely negligible, the main point here
being that this encapsulates libuv request management a bit more.)
@bcoe Mostly doing this because of our conversation – it’s nicer if we make existing code rely less on what exactly
datapoints to :)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes