Skip to content

doc: update readme with my pronouns#21818

Closed
lance wants to merge 1 commit intonodejs:masterfrom
lance:my-pronouns
Closed

doc: update readme with my pronouns#21818
lance wants to merge 1 commit intonodejs:masterfrom
lance:my-pronouns

Conversation

@lance
Copy link
Member

@lance lance commented Jul 15, 2018

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

Ref: #21803

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2018

@lance build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/278/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 15, 2018
@lance lance mentioned this pull request Jul 15, 2018
Closed
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 15, 2018
@Trott
Copy link
Member

Trott commented Jul 15, 2018

👍 here to fast-track

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2018
@lance
Copy link
Member Author

lance commented Jul 15, 2018

Landed in c7707a1

@lance lance closed this Jul 15, 2018
targos pushed a commit that referenced this pull request Jul 15, 2018
@lance @targos
doc: update readme with my pronouns
ca8c960 
PR-URL: #21818
Refs: #21803
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@codebytere codebytere codebytere approved these changes

@targos targos targos approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lance @nodejs-github-bot @Trott @benjamingr @codebytere @targos @vsemozhetbyt