Closed
Conversation
Trott
added
blocked
mscdex
reviewed
Jul 11, 2018
| * @type String | ||
| */ | ||
| 'version': '2.0.0', | ||
| 'version': '2.1.0', |
Contributor
There was a problem hiding this comment.
Is this correct? The PR title says this is an upgrade to 2.1.1?
Member
Author
There was a problem hiding this comment.
I did npm install punycode@2.1.1 so...uh...mistake in the punycode release? /cc @mathiasbynens
Member
There was a problem hiding this comment.
That was missed in the 2.1.1 release. The code did not change in that release so it should be fine to land this as is.
BridgeAR
approved these changes
Jul 12, 2018
Member
|
@Trott let / var can also be an issue on 8 but that is not likely anymore, especially in these cases. |
BridgeAR
added
the
author ready
Member
Author
|
Unblocking. PTAL |
Member
Author
hiroppy
approved these changes
Jul 15, 2018
TimothyGu
approved these changes
Jul 15, 2018
cjihrig
approved these changes
Jul 16, 2018
trivikr
approved these changes
Jul 16, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 16, 2018
PR-URL: nodejs#21768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
Landed in ab10bfe |
targos
pushed a commit
that referenced
this pull request
Jul 17, 2018
PR-URL: #21768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked to give deference to a potential pull request resulting from #21761. If the OP there doesn't open something in a few days, this can land.
I'm not concerned about the
var/letin loop stuff. This is legacy/deprecated. But just to be on the safe side, I'll add labels to indicate this should not land on 6.x , where the version of V8 is such that the wholelet-in-loops thing matters.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes