Skip to content

src: add comment on CallbackScope exception behaviour#21743

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:callback-scope-verbose
Closed

src: add comment on CallbackScope exception behaviour#21743
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:callback-scope-verbose

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jul 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax addaleax requested a review from codebytere July 10, 2018 23:29
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 10, 2018

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/247/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 10, 2018
codebytere
codebytere approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
@addaleax
Copy link
Member Author

addaleax commented Jul 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15862/

@addaleax
Copy link
Member Author

addaleax commented Jul 14, 2018

Landed in 1062ea4

@addaleax addaleax closed this Jul 14, 2018
@addaleax addaleax deleted the callback-scope-verbose branch July 14, 2018 09:55
addaleax added a commit that referenced this pull request Jul 14, 2018
@addaleax
src: add comment on CallbackScope exception behaviour
1062ea4 
PR-URL: #21743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 14, 2018
@addaleax @targos
src: add comment on CallbackScope exception behaviour
cb69811 
PR-URL: #21743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@codebytere codebytere codebytere approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax @nodejs-github-bot @jasnell @codebytere @cjihrig @BridgeAR