[v8.x backport] test: remove --harmony-sharedarraybuffer usage#21717
Closed
BethGriggs wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x backport] test: remove --harmony-sharedarraybuffer usage#21717BethGriggs wants to merge 1 commit intonodejs:v8.x-stagingfrom
BethGriggs wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
This flag has been enabled by default since v8 7662e0634c3a057fa5d746912ee5af76e285c274. PR-URL: nodejs#16343 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
addaleax
approved these changes
Jul 9, 2018
Member
Member
|
Landed in 4be5252 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.
PR-URL: #16343
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anatoli Papirovski apapirovski@mac.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport, as requested, of #16343