test: fix parallel/test-tls-env-extra-ca.js#21647
Closed
Niicck wants to merge 1 commit intonodejs:masterfrom
Niicck:test-tls-env-extra-ca
Closed
test: fix parallel/test-tls-env-extra-ca.js#21647Niicck wants to merge 1 commit intonodejs:masterfrom Niicck:test-tls-env-extra-ca
Niicck wants to merge 1 commit intonodejs:masterfrom
Niicck:test-tls-env-extra-ca
Conversation
fix args in final assert.strictEqual() call
Trott
approved these changes
Jul 4, 2018
Member
Trott
added
the
author ready
trivikr
approved these changes
Jul 4, 2018
cjihrig
approved these changes
Jul 4, 2018
lpinca
approved these changes
Jul 4, 2018
JungMinu
approved these changes
Jul 5, 2018
trivikr
pushed a commit
that referenced
this pull request
Jul 10, 2018
fix args in final assert.strictEqual() call PR-URL: #21647 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Member
targos
pushed a commit
that referenced
this pull request
Jul 10, 2018
fix args in final assert.strictEqual() call PR-URL: #21647 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix args in final assert.strictEqual() call
make -j4 test(UNIX), orvcbuild test(Windows) passes