zlib: track memory allocated by zlib#21608
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Provide a custom memory allocator for zlib, and track memory allocated by the library with it. Right now this “only” makes reported external memory usage (much) more accurate and protects against zlib memory leaks, but it generally will enable us to give more accurate memory usage statistics for zlib.
nodejs-github-bot
added
c++
Member
Author
|
@danbev @apapirovski @jasnell Would any of you be interested in reviewing this? |
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15713/ (edit: ✔️) |
danbev
approved these changes
Jul 4, 2018
addaleax
added
the
author ready
mhdawson
approved these changes
Jul 4, 2018
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM. Would be nice to share more across other places in the codebase, but looks like an improvement over what was there.
jasnell
approved these changes
Jul 10, 2018
Member
Author
|
Landed in ed715ef |
addaleax
added a commit
that referenced
this pull request
Jul 10, 2018
Provide a custom memory allocator for zlib, and track memory allocated by the library with it. Right now this “only” makes reported external memory usage (much) more accurate and protects against zlib memory leaks, but it generally will enable us to give more accurate memory usage statistics for zlib. PR-URL: #21608 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
Provide a custom memory allocator for zlib, and track memory allocated by the library with it. Right now this “only” makes reported external memory usage (much) more accurate and protects against zlib memory leaks, but it generally will enable us to give more accurate memory usage statistics for zlib. PR-URL: #21608 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jul 18, 2018
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a custom memory allocator for zlib, and track
memory allocated by the library with it.
Right now this “only” makes reported external memory
usage (much) more accurate and protects against zlib memory leaks,
but it generally will enable us to give more accurate memory
usage statistics for zlib.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes