[v8.x] src: add convenience ctor for async trigger id scope#21600
Closed
addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x] src: add convenience ctor for async trigger id scope#21600addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. PR-URL: nodejs#19204
nodejs-github-bot
added
c++
MylesBorins
pushed a commit
that referenced
this pull request
Jul 13, 2018
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. Backport-PR-URL: #21600 PR-URL: #19204 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Contributor
|
landed in 0d41b02 |
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. Backport-PR-URL: #21600 PR-URL: #19204 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport differs from the original only in the
omission of a change to
stream_base-inl.hwhichwould have generated conflicts.
PR-URL: #19204
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes