[v8.x] test: add http _dump regression test#21595
Closed
addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
[v8.x] test: add http _dump regression test#21595addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
addaleax wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
Test part of 299da1f, specifically for v8.x.
addaleax
changed the title
Member
Author
|
Only test failure in the automated run is a known flake, being tracked at #21188 Can somebody give this a quick LGTM? It’s a clean copy of the original test, so it’s enough to hear an approval in the sense of an enthusiastic ”yes let’s add a test that contains already-reviewed code” |
apapirovski
approved these changes
Jun 30, 2018
lpinca
approved these changes
Jun 30, 2018
Member
Author
|
Landed in 5b64d26 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test part of 299da1f, specifically for v8.x.