child_process: add the --windows-hide flag

[ryzokuken]

Add a flag called --windows-hide that hides console windows for newly spawned
processes by default on Windows.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

/cc @nodejs/child_process @nodejs/delivery-channels @codebytere

This should work, but I might be wrong. Thinking of adding tests for this, suggestions welcome.

[nodejs-github-bot]

@ryzokuken build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/52/pipeline

[vsemozhetbyt]

Will this be documented?

[cjihrig]

Is this in response to libuv/libuv#1878 (comment)? My idea there was that windowsHide should just default to true instead of false as it currently does.

[ryzokuken]

@cjihrig it is. I'd be submitting another semver-major for that. The motivation behind this PR was that it could land as a semver-minor, allowing the electron team for get this change more quickly.

[ryzokuken]

@vsemozhetbyt because this is only meant for embedders, I chose against printing out the flag in the PrintHelp function, but we should probably document it elsewhere. Would love to hear your opinions on this.

[cjihrig]

I'm not really a fan of adding a new config value for this. A semver major could be released in a few months in Node 11. The patch Electron is floating to work around this is pretty trivial. I don't think it would be much of a maintenance burden to carry for a couple months.

EDIT: For reference, the patch is here, and has already been floated for 5 years.

[apapirovski]

I'm in agreement with @cjihrig on this.

[ryzokuken]

@cjihrig @apapirovski I'm okay with closing this if the electron peeps don't want this either and agree with you 😄

[ryzokuken]

The patch Electron is floating to work around this is pretty trivial. I don't think it would be much of a maintenance burden to carry for a couple months.

@cjihrig you're right about this, and I talked to @codebytere who seemed to concur with you on this as well, so I'm closing this. Following up with a semver-major.