tests,aix: avoid running fsync on directory#21298
Closed
jBarz wants to merge 1 commit intonodejs:masterfrom
Closed
tests,aix: avoid running fsync on directory#21298jBarz wants to merge 1 commit intonodejs:masterfrom
jBarz wants to merge 1 commit intonodejs:masterfrom
Conversation
The underlying fsync system call returns EBADF on a file descriptor for an open directory. So avoid running fsync on it.
richardlau
reviewed
Jun 13, 2018
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Test changes look okay, but this behaviour should probably be documented.
Is the underlying fsync call in libuv and, if so, should it be handled/documented there?
Contributor
Author
|
Yea, the |
gireeshpunathil
approved these changes
Jun 13, 2018
cjihrig
approved these changes
Jun 13, 2018
richardlau
approved these changes
Jun 13, 2018
Member
|
For reference, libuv doc PR: libuv/libuv#1879 |
Member
addaleax
added
the
author ready
jasnell
approved these changes
Jun 14, 2018
cjihrig
pushed a commit
to libuv/libuv
that referenced
this pull request
Jun 19, 2018
Unlike other platforms, the fsync call on aix will not accept non-regular file file-descriptors. Refs: nodejs/node#21298 PR-URL: #1879 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Contributor
Author
|
I think this is good to go. |
richardlau
pushed a commit
that referenced
this pull request
Jun 22, 2018
On AIX the underlying fsync system call returns EBADF on a file descriptor for an open directory. So avoid running fsync on it. PR-URL: #21298 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Amended commit message and landed in 8689c78. |
targos
pushed a commit
that referenced
this pull request
Jun 24, 2018
On AIX the underlying fsync system call returns EBADF on a file descriptor for an open directory. So avoid running fsync on it. PR-URL: #21298 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Mar 21, 2019
On AIX the underlying fsync system call returns EBADF on a file descriptor for an open directory. So avoid running fsync on it. PR-URL: #21298 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying fsync system call returns EBADF on a file descriptor
for an open directory. So avoid running fsync on it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes