Fix configure script to work with Apple Clang 10#21200
Closed
saagarjha wants to merge 1 commit intonodejs:masterfrom
Closed
Fix configure script to work with Apple Clang 10#21200saagarjha wants to merge 1 commit intonodejs:masterfrom
saagarjha wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
Hi @saagarjha, thanks for taking this on. It appears there's already an earlier PR implementing a similar change: #21183 |
Contributor
Author
|
Sorry, my bad. I should have searched before making the pull request rather than checking when I had the issue yesterday. However, I did look through that pull request, it seems like my code has an additional patch that @mistydemeo's branch doesn't in $ ./configure
ERROR: Did not find a new enough assembler, install one or build with
--openssl-no-asm.
Please refer to BUILDING.md |
Contributor
|
@saagarjha See #21173 for that. |
Contributor
Author
|
Ah, got it. In that case I guess I'll close this pull request and let you guys merge those instead. Though, might I suggest using Python's built-in tuple comparison operator rather than rolling our own? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis is a simple fix to the configure script so it doesn't spuriously drop out for newer versions of Apple's Clang:
Please do let me know if there's something wrong with my implementation; I haven't tested this on systems other than macOS so it might have silently broke something there.