[v8.x backport] net: remove Socket.prototype.listen

[codebytere]

Original PR: #13735

Checklist

• make -j4 test passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[ryzokuken]

CI: https://ci.nodejs.org/job/node-test-pull-request/15373/

[ryzokuken]

Okay, tests finally passed.

@MylesBorins shall we land this?

[MylesBorins]

My only concern with landing this is that it has the risk of breaking something on 8.x that we don't know about. I'm not sure this actually makes sense for LTS at the moment without someone else chiming in... specifically because we don't really have anything huge to gain by landing it, but if we have even a 1% risk of breaking things we likely shouldn't.

Perhaps we should run citgm?

[ryzokuken]

@MylesBorins it's an undocumented and defunct method, and I hope nobody from the ecosystem is using it, but yeah, why not run CITGM and know for sure?

[joyeecheung]

Landing on v8.x this seems to break our LTS policy..this has been released in v9.x but has never been tested in older release lines.

[codebytere]

@joyeecheung is there a way i can tell if that's the case from looking at PRs which have the backport-requested label? At present i was just looking through the lists from LTS and current for closed PRs which have the label but i'd like to ensure i'm doing work that helps yall and doesn't break policies!

[TimothyGu]

@codebytere Unfortunately, we are behind on triaging pull requests for backporting… I’ve manually unmarked the original PR for backporting, but I don’t really have a good way for you tell which ones should be backported, other than comparing a change to our LTS policies (no potential breaking changes of any kind, unless the API is experimental). Sorry about that.

[codebytere]

@TimothyGu no worries, thanks! Should this backport be closed?

[ryzokuken]

@codebytere yes, please close this if it's okay.

[joyeecheung]

@codebytere What @TimothyGu said, sorry about the confusion. We probably should've marked that PR dont-land-on-v8.x before it lands, there are no clear documentation on how to triage PRs like that but in general, removing methods/properties, even the undocumented ones, should be treated with care.

[codebytere]

thanks @joyeecheung, appreciate the context!