build,win: disable DLL-interface warnings#20958
build,win: disable DLL-interface warnings#20958piscisaureus wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
piscisaureus
force-pushed
the
warnings
branch
2 times, most recently
from
fd8e255 to
65ceed1
Compare
|
This came up before. See #15570 I guess we should indeed do this even though this should get fixed by Microsoft. |
|
Good to see that the root cause is being addressed. Scrolling back in the terminal has become a thing of the past. People can't work like that. |
|
I think it would be good to add a TODO to remove those two again as soon as it got fixed upstream. And please also open an issue at Microsoft https://developercommunity.visualstudio.com/spaces/62/index.html. |
|
@nodejs/build PTAL |
BridgeAR
added
the
author ready
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM with a TODO as suggested
|
No objections, but just noting that since this is |
Compiling node with vcbuild generates 10,000s of these warnings, originating from v8.h. This makes it impossible to read any other diagnostic messages. Refs: nodejs#15570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#20958
|
@BridgeAR, @nodejs/build: Added the TODO item; PTAL. |
|
Note that I don't seem to have commit rights. Someone has to push the button for me. |
The push button is not used in this repo. According to |
|
Landed in 4f28015, thanks! |
Compiling node with vcbuild generates 10,000s of these warnings, originating from v8.h. This makes it impossible to read any other diagnostic messages. PR-URL: #20958 Refs: #15570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@piscisaureus That's because you were moved to Collaborator Emeriti in #16173. I'd suggest asking @nodejs/TSC if you wish to be moved back to Collaborator status. |
Should have been @nodejs/tsc. |
Compiling node with vcbuild generates 10,000s of these warnings, originating from v8.h. This makes it impossible to read any other diagnostic messages. PR-URL: #20958 Refs: #15570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
7 participants
Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes