doc: count's signature should match countReset#20599
Closed
Lambdac0re wants to merge 1 commit intonodejs:masterfrom
Lambdac0re:patch-2
Closed
doc: count's signature should match countReset#20599Lambdac0re wants to merge 1 commit intonodejs:masterfrom Lambdac0re:patch-2
Lambdac0re wants to merge 1 commit intonodejs:masterfrom
Lambdac0re:patch-2
Conversation
nodejs-github-bot
added
console
vsemozhetbyt
approved these changes
May 8, 2018
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
vsemozhetbyt
added
fast-track
trivikr
approved these changes
May 8, 2018
cjihrig
approved these changes
May 8, 2018
Contributor
|
Landed in cf44abb |
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20599 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20599 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20599 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
PR-URL: #20599 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist