doc: add parameters for Http2Session:stream event#20547
Closed
ryzokuken wants to merge 2 commits intonodejs:masterfrom
Closed
doc: add parameters for Http2Session:stream event#20547ryzokuken wants to merge 2 commits intonodejs:masterfrom
ryzokuken wants to merge 2 commits intonodejs:masterfrom
Conversation
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment)
nodejs-github-bot
added
doc
Contributor
Author
|
Also, please respond with 👍 to approve fast-tracking. |
Contributor
Author
addaleax
reviewed
May 5, 2018
doc/api/http2.md
Outdated
| * `stream` {Http2Stream} A reference to the stream | ||
| * `headers` {HTTP/2 Headers Object} An object describing the headers | ||
| * `flags` {number} The associated numeric flags | ||
| * `rawHeaders` {Array} An array containing the raw header name value pairs |
Member
There was a problem hiding this comment.
Is this actually supposed to be public? @nodejs/http2
Contributor
There was a problem hiding this comment.
I am not sure what is the convention here, but maybe name value -> name-value or name/value or name:value (with or without spaces, I am not sure as well)?
Member
There was a problem hiding this comment.
Yes it's correct. rawHeaders is exposed as request.rawHeaders.
Contributor
Author
There was a problem hiding this comment.
@vsemozhetbyt I think it could be either depending on the key:value delimiter? Let me check what the delimiter is in this particular case.
addaleax
approved these changes
May 5, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but have a question about rawHeaders
vsemozhetbyt
approved these changes
May 5, 2018
trivikr
approved these changes
May 5, 2018
vsemozhetbyt
added
fast-track
Contributor
Author
|
P.S. Checked it out by running an actual example, and the strings weren't |
Contributor
Author
|
@vsemozhetbyt take another look? |
Contributor
|
LGTM. |
Contributor
Author
|
CI passed, landing this. |
Contributor
Author
|
BTW, @vsemozhetbyt I wanted to talk to you about a thing or two regarding docs, but couldn't find you on IRC. How can I reach out to you? |
Contributor
Author
|
Landed in 29ccf6e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 7, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
|
@ryzokuken I do not monitor IRC, but the email in the GitHub profile is live) |
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 11, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 19, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Add parameters for the callback for the Http2Session:stream event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) Backport-PR-URL: #22850 PR-URL: #20547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameters for the callback for the Http2Session:stream event
inline with the pattern in the rest of the documentation.
Refs: nodejs/help#877 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesP.S. I was kinda confused regarding the type of the
flagsvariable, so I set it toNumberfor now./cc @nodejs/http2 @mcollina @vsemozhetbyt