clarification: not EventEmitter but its instance#20537
Closed
dagolinuxoid wants to merge 2 commits intonodejs:masterfrom
dagolinuxoid:patch-1
Closed
clarification: not EventEmitter but its instance#20537dagolinuxoid wants to merge 2 commits intonodejs:masterfrom dagolinuxoid:patch-1
dagolinuxoid wants to merge 2 commits intonodejs:masterfrom
dagolinuxoid:patch-1
Conversation
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter. Maybe adding this=== myEmitter to an example down below is redundant so feel free to modify it as well or rather keep it unchanged.
nodejs-github-bot
added
doc
vsemozhetbyt
reviewed
May 5, 2018
Contributor
vsemozhetbyt
left a comment
vsemozhetbyt
left a comment
There was a problem hiding this comment.
Thank you. There is a linting nit in the changes.
doc/api/events.md
Outdated
| ordinary listener function is called by the `EventEmitter`, the standard `this` | ||
| keyword is intentionally set to reference the `EventEmitter` to which the | ||
| ordinary listener function is called, the standard `this` | ||
| keyword is intentionally set to reference the `EventEmitter` instance to which the |
Contributor
There was a problem hiding this comment.
This line needs to be wrapped maximum at 80 characters to pass doc linting.
addaleax
approved these changes
May 5, 2018
cjihrig
approved these changes
May 5, 2018
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM once the linter passes.
jasnell
approved these changes
May 6, 2018
trivikr
approved these changes
May 6, 2018
Contributor
vsemozhetbyt
added
fast-track
TimothyGu
approved these changes
May 7, 2018
Contributor
|
@dagolinuxoid Can you fix the linting issue? |
Looking good? I bound it to 80 chars.
Contributor
Author
|
@vsemozhetbyt looking good now? |
Contributor
vsemozhetbyt
approved these changes
May 8, 2018
vsemozhetbyt
added
the
author ready
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 8, 2018
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter. PR-URL: #20537 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Contributor
|
Landed in 2d945fd |
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter. PR-URL: #20537 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter. PR-URL: #20537 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter. PR-URL: #20537 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this === eventEmitter or this === instance of EventEmitter, but it's this is not EventEmitter.
Maybe adding this=== myEmitter to an example down below is redundant so feel free to modify it as well or rather keep it unchanged.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes