Skip to content

doc: move tunniclm to Emeritus#20533

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:add-to-emeritus
Closed

doc: move tunniclm to Emeritus#20533
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:add-to-emeritus

Conversation

@Trott
Copy link
Member

@Trott Trott commented May 5, 2018

tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

Checklist

@Trott
doc: move tunniclm to Emeritus
dde13ad 
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2018
@Trott
Copy link
Member Author

Trott commented May 5, 2018

/ping @tunniclm just in case I misunderstood

@Trott
Copy link
Member Author

Trott commented May 5, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/669/

@Trott
Copy link
Member Author

Trott commented May 5, 2018

LinuxONE rerun: https://ci.nodejs.org/job/node-test-commit-linuxone/1001/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2018
@richardlau
Copy link
Member

richardlau commented May 5, 2018

LGTM.

@addaleax addaleax added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels May 5, 2018
mhdawson
mhdawson approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented May 8, 2018

Landed in dd03709

@Trott Trott closed this May 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 8, 2018
@Trott
doc: move tunniclm to Emeritus
dd03709 
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

PR-URL: nodejs#20533
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@Trott @MylesBorins
doc: move tunniclm to Emeritus
e2fb920 
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

PR-URL: #20533
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@Trott @MylesBorins
doc: move tunniclm to Emeritus
b172f6b 
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

PR-URL: #20533
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@Trott @MylesBorins
doc: move tunniclm to Emeritus
bd27a59 
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

PR-URL: #20533
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott deleted the add-to-emeritus branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

@trivikr trivikr trivikr approved these changes

+3 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@hiroppy hiroppy hiroppy approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.