tools: remove redundant code in doc/html.js#20514
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-html-remove-unneeded
Closed
tools: remove redundant code in doc/html.js#20514vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:tools-doc-html-remove-unneeded
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:tools-doc-html-remove-unneeded
Conversation
Contributor
Author
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
Author
Member
|
@vsemozhetbyt I am really glad you look into these things and improve our docs tooling! 👍 |
Contributor
Author
|
@BridgeAR Thank you! |
tniessen
approved these changes
May 5, 2018
Member
tniessen
left a comment
There was a problem hiding this comment.
Glad to see changes which reduce the size of our codebase!
Contributor
|
Landed in 974df9c. Thanks @vsemozhetbyt! |
apapirovski
pushed a commit
that referenced
this pull request
May 7, 2018
This PR reduces code by 40 lines and docs size by ~7.5 KB. Only <div class="signature">...</div> wrappers are removed from docs, no other changes are found in results. PR-URL: #20514 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This PR reduces code by 40 lines and docs size by ~7.5 KB. Only <div class="signature">...</div> wrappers are removed from docs, no other changes are found in results. PR-URL: #20514 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This PR reduces code by 40 lines and docs size by ~7.5 KB. Only <div class="signature">...</div> wrappers are removed from docs, no other changes are found in results. PR-URL: #20514 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
This PR reduces code by 40 lines and docs size by ~7.5 KB. Only <div class="signature">...</div> wrappers are removed from docs, no other changes are found in results. PR-URL: #20514 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesStatus quo
Currently,
parseLists()function intools/doc/html.jshas some flaws:<div class="signature">...</div>elements around lists of signature types (function parameters, returned values, property types). However, we have no such class in ourapi_assets\style.css, so this wrapping list blocks inDIVblocks is redundant.Fixing strategy
DIVwrapping for lists.This PR reduces code by 40 lines and docs size by ~7.5 KB. Only
<div class="signature">...</div>wrappers are removed from docs, no other changes are found in results.The visible styles of wrapped and unwrapped lists are identical:
cc @nodejs/documentation