console: console.table() uses colored inspect#20510
Closed
makenowjust wants to merge 1 commit intonodejs:masterfrom
Closed
console: console.table() uses colored inspect#20510makenowjust wants to merge 1 commit intonodejs:masterfrom
makenowjust wants to merge 1 commit intonodejs:masterfrom
Conversation
This makes console.table() inspect objects with color if available like `console.log`.
nodejs-github-bot
added
the
console
Contributor
Contributor
|
cc @devsnek @TimothyGu @BridgeAR as per #18137 |
jasnell
added
the
semver-minor
devsnek
approved these changes
May 4, 2018
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
looks ok, although I would think this is patch not minor
vsemozhetbyt
added
the
author ready
TimothyGu
approved these changes
May 4, 2018
trivikr
approved these changes
May 5, 2018
Member
|
General note: we should likely consider adding more default options here as the defaults might have been manipulated by the user or modules. But that is out of the scope of this PR. |
JacksonTian
approved these changes
May 5, 2018
jasnell
approved these changes
May 6, 2018
Contributor
|
Landed in 6af26b1 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 8, 2018
This makes `console.table()` inspect objects with color if available like `console.log()`. PR-URL: #20510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This makes `console.table()` inspect objects with color if available like `console.log()`. PR-URL: #20510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
May 8, 2018
Notable Changes:
* console:
- make console.table() use colored inspect (TSUYUSATO Kitsune)
#20510
* fs:
- move fs/promises to fs.promises (cjihrig)
#20504
* http:
- added aborted property to request (Robert Nagy)
#20094
* n-api:
- initialize a module via a special symbol (Gabriel Schulhof)
#20161
* src:
- add public API to expose the main V8 Platform (Allen Yonghuang Wang)
#20447
PR-URL: Coming Soon
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This makes `console.table()` inspect objects with color if available like `console.log()`. PR-URL: #20510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
May 8, 2018
Notable Changes:
* console:
- make console.table() use colored inspect (TSUYUSATO Kitsune)
#20510
* fs:
- move fs/promises to fs.promises (cjihrig)
#20504
* http:
- added aborted property to request (Robert Nagy)
#20094
* n-api:
- initialize a module via a special symbol (Gabriel Schulhof)
#20161
* src:
- add public API to expose the main V8 Platform (Allen Yonghuang Wang)
#20447
PR-URL: #20606
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
This makes `console.table()` inspect objects with color if available like `console.log()`. PR-URL: #20510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
May 9, 2018
Notable Changes:
* console:
- make console.table() use colored inspect (TSUYUSATO Kitsune)
#20510
* fs:
- move fs/promises to fs.promises (cjihrig)
#20504
* http:
- added aborted property to request (Robert Nagy)
#20094
* n-api:
- initialize a module via a special symbol (Gabriel Schulhof)
#20161
* src:
- add public API to expose the main V8 Platform (Allen Yonghuang Wang)
#20447
PR-URL: #20606
MylesBorins
added a commit
that referenced
this pull request
May 9, 2018
Notable Changes:
* console:
- make console.table() use colored inspect (TSUYUSATO Kitsune)
#20510
* fs:
- move fs/promises to fs.promises (cjihrig)
#20504
* http:
- added aborted property to request (Robert Nagy)
#20094
* n-api:
- initialize a module via a special symbol (Gabriel Schulhof)
#20161
* src:
- add public API to expose the main V8 Platform (Allen Yonghuang Wang)
#20447
PR-URL: #20606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
console.table()inspect objects with color if available likeconsole.log.Currently
console.tablewithtrue,false,nullorundefinedshows colored values because it callsconsole.loginternally.However
console.tablewith objects does not show colored value at all.It seems a bug and I wish
console.tableshows colored values.I'm first time contributor. I have a questions: Is this PR change just a bug fixing? -- Or breaking change?
Probably it is the important concern of
nodejs/node, which is used for versioning. I can't determine that. What do you think?Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes