Skip to content

doc: updates command (openssl list -digest-algorithms') at one more place#20500

Closed
shobhitchittora wants to merge 1 commit intonodejs:masterfrom
shobhitchittora:update-list-digest-crypto
Closed

doc: updates command (openssl list -digest-algorithms') at one more place#20500
shobhitchittora wants to merge 1 commit intonodejs:masterfrom
shobhitchittora:update-list-digest-crypto

Conversation

@shobhitchittora
Copy link
Contributor

@shobhitchittora shobhitchittora commented May 3, 2018

Refs: #20400

  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels May 3, 2018
@shobhitchittora
Copy link
Contributor Author

shobhitchittora commented May 3, 2018 •
edited
Loading

@vsemozhetbyt here. I missed this change in the last PR. 😂

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 3, 2018

As this is the same change as already landed for another doc fragment, Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 3, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/655/
cc @nodejs/crypto

@tniessen
Copy link
Member

tniessen commented May 3, 2018 •
edited
Loading

Nit: typo in commit message (can be fixed while landing)

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 3, 2018
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 7, 2018

Landed in 5efbe4c
Thank you.

vsemozhetbyt pushed a commit that referenced this pull request May 7, 2018
@shobhitchittora @vsemozhetbyt
doc: update one more command in crypto.md
5efbe4c 
PR-URL: #20500
Refs: #20400
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@shobhitchittora @MylesBorins
doc: update one more command in crypto.md
aef4f80 
PR-URL: #20500
Refs: #20400
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@shobhitchittora @MylesBorins
doc: update one more command in crypto.md
38323bc 
PR-URL: #20500
Refs: #20400
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@shobhitchittora @MylesBorins
doc: update one more command in crypto.md
bea4ffc 
PR-URL: #20500
Refs: #20400
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shobhitchittora @vsemozhetbyt @tniessen @trivikr @nodejs-github-bot