tls: remove sharedCreds in Server constructor#20491
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
tls: remove sharedCreds in Server constructor#20491danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line.
Contributor
Author
lpinca
approved these changes
May 3, 2018
cjihrig
approved these changes
May 3, 2018
jasnell
approved these changes
May 3, 2018
addaleax
approved these changes
May 3, 2018
BridgeAR
approved these changes
May 5, 2018
BridgeAR
added
the
author ready
addaleax
pushed a commit
that referenced
this pull request
May 6, 2018
This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line. PR-URL: #20491 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 161182e |
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line. PR-URL: #20491 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line. PR-URL: #20491 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line. PR-URL: #20491 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the var sharedCreds which is just reassigned to
this._sharedCreds in the following line.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes