benchmark: fix next-tick-depth#20461
Closed
apapirovski wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
A recent change made this benchmark fail by always finishing with 0 iterations. Restore a counter variable.
apapirovski
added
the
benchmark
nodejs-github-bot
added
the
process
apapirovski
added
the
fast-track
Contributor
Author
|
Please 👍 to approve fast-tracking. |
Contributor
Author
BridgeAR
approved these changes
May 2, 2018
BridgeAR
added
the
author ready
Contributor
Author
|
Missed that |
Trott
approved these changes
May 2, 2018
apapirovski
removed
the
fast-track
Contributor
Author
Member
Yes. |
apapirovski
added
the
fast-track
Contributor
Author
|
Landed in a957f24 |
apapirovski
added a commit
that referenced
this pull request
May 3, 2018
A recent change made these benchmarks fail by always finishing with 0 iterations. Restore a counter variable. PR-URL: #20461 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
A recent change made these benchmarks fail by always finishing with 0 iterations. Restore a counter variable. PR-URL: #20461 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
A recent change made these benchmarks fail by always finishing with 0 iterations. Restore a counter variable. PR-URL: #20461 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change made this benchmark fail by always finishing with 0 iterations. Restore a counter variable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes