Closed
Conversation
Member
|
LGTM. I don't see a reason to keep them around. Can you put your rationale in the commit log? |
Contributor
|
sweet, they're in git anyways so I'm not sure why they were kept in the first place |
Tests in the disabled directory are not used by Makefile nor by the CI. Other than a single 2015 commit that puts 'use strict' in each test, many of them haven't been touched in years. This removes all the disabled tests that have been unmodified since 2011 (with the exception of the 'use strict' modification mentioned above).
Member
Author
|
Commit message amended per @bnoordhuis |
Contributor
|
LGTM |
Member
We (Ryan, Bert, Igor, me) moved a lot of tests to test/disabled when we were porting node.js to Windows, piecemeal moving them back whenever libuv grew the required functionality. What's left are tests for functionality that was too UNIX-specific or too libev/libeio-centric. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 25, 2015
Tests in the disabled directory are not used by Makefile nor by the CI. Other than a single 2015 commit that puts 'use strict' in each test, many of them haven't been touched in years. This removes all the disabled tests that have been unmodified since 2011 (with the exception of the 'use strict' modification mentioned above). PR-URL: nodejs#2045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
Member
Author
|
Merged in 856c11f |
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Tests in the disabled directory are not used by Makefile nor by the CI. Other than a single 2015 commit that puts 'use strict' in each test, many of them haven't been touched in years. This removes all the disabled tests that have been unmodified since 2011 (with the exception of the 'use strict' modification mentioned above). PR-URL: nodejs#2045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many tests in the
test/disableddirectory. These tests are not used byMakefilenor by the CI. Other than a single 2015 commit that puts'use strict'in each test, many of them haven't been touched in years.This removes all the disabled tests that have been unmodified since 2011 (with the exception of the
'use strict'modification mentioned above).I concede in advance that my main motive is a perhaps-misguided mission to eliminate every
TODOcomment possible in the code base.