src: fix inconsistency in extern declaration#20436
Closed
hashseed wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix inconsistency in extern declaration#20436hashseed wants to merge 1 commit intonodejs:masterfrom
hashseed wants to merge 1 commit intonodejs:masterfrom
Conversation
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl.
nodejs-github-bot
added
c++
TimothyGu
approved these changes
Apr 30, 2018
Member
Author
addaleax
approved these changes
Apr 30, 2018
refack
approved these changes
Apr 30, 2018
bnoordhuis
approved these changes
Apr 30, 2018
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Back-linking to v8#67 for posterity.
BridgeAR
added
author ready
cjihrig
approved these changes
May 1, 2018
tniessen
approved these changes
May 1, 2018
Member
|
Landed in 4546ad2 |
addaleax
pushed a commit
that referenced
this pull request
May 5, 2018
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: #20436 Refs: #19630 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: #20436 Refs: #19630 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: #20436 Refs: #19630 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
NodeCounterProvider is declared as extern but defined as EXTERN_C. This confuses clang-cl. PR-URL: #20436 Refs: #19630 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeCounterProvider is declared as
externbut defined asEXTERN_C.This confuses clang-cl.
Refs: #19630
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes