timers: named anonymous functions#20397
Closed
js-kyle wants to merge 1 commit intonodejs:masterfrom
js-kyle:timers_named_functions
Closed
timers: named anonymous functions#20397js-kyle wants to merge 1 commit intonodejs:masterfrom js-kyle:timers_named_functions
js-kyle wants to merge 1 commit intonodejs:masterfrom
js-kyle:timers_named_functions
Conversation
nodejs-github-bot
added
the
timers
Contributor
JungMinu
approved these changes
Apr 29, 2018
BridgeAR
approved these changes
Apr 29, 2018
BridgeAR
added
fast-track
benjamingr
approved these changes
Apr 29, 2018
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
trivikr
approved these changes
Apr 29, 2018
lpinca
approved these changes
Apr 29, 2018
TimothyGu
approved these changes
Apr 29, 2018
trivikr
pushed a commit
that referenced
this pull request
May 3, 2018
PR-URL: #20397 Refs: #8913 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Member
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20397 Refs: #8913 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20397 Refs: #8913 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRef: #8913