doc: remove parenthetical in onboarding-extras#20393
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove parenthetical in onboarding-extras#20393Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove "(I prefer the former)" from onboarding-extras. Without any explanation as to why one might prefer A over B, it probably raises more questions than it answers.
Member
Author
Member
Author
|
If you're a Collaborator and think this can be fast-tracked, please leave a 👍 on this comment. Thanks. |
vsemozhetbyt
approved these changes
Apr 29, 2018
tniessen
approved these changes
Apr 29, 2018
richardlau
approved these changes
Apr 29, 2018
BridgeAR
approved these changes
Apr 29, 2018
Member
|
Independent from this PR: should we maybe document what the specific commands stand for that we ask to be executed? |
BridgeAR
added
the
author ready
trivikr
approved these changes
Apr 29, 2018
Member
Author
@BridgeAR Perhaps, although there is already a similar command in COLLABORATOR_GUIDE.md (a third variation to add to the two suggested here!) and the explanation should live there, not here, if an explanation is needed beyond the context. The entries in this doc should be removed or else incorporated into COLLABORATOR_GUIDE.md IMO. |
Member
Author
|
Landed in 45c7e03 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2018
Remove "(I prefer the former)" from onboarding-extras. Without any explanation as to why one might prefer A over B, it probably raises more questions than it answers. PR-URL: nodejs#20393 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Remove "(I prefer the former)" from onboarding-extras. Without any explanation as to why one might prefer A over B, it probably raises more questions than it answers. PR-URL: #20393 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove "(I prefer the former)" from onboarding-extras. Without any
explanation as to why one might prefer A over B, it probably raises more
questions than it answers.
Checklist