assert: minor assert error message improvements#20315
Closed
BridgeAR wants to merge 3 commits intonodejs:masterfrom
Closed
assert: minor assert error message improvements#20315BridgeAR wants to merge 3 commits intonodejs:masterfrom
BridgeAR wants to merge 3 commits intonodejs:masterfrom
Conversation
Adjust indentations and fix a typo.
nodejs-github-bot
added
the
errors
If lines gets skipped, they are marked with three dots. This makes sure they are better visualized to distinguish them from everything else.
BridgeAR
force-pushed
the
minor-assert-error-improvements
branch
from
d9399ba to
bef57a6
Compare
danbev
approved these changes
Apr 26, 2018
BridgeAR
added
the
author ready
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2018
Adjust indentations and fix a typo. PR-URL: nodejs#20315 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2018
If lines gets skipped, they are marked with three dots. This makes sure they are better visualized to distinguish them from everything else. PR-URL: nodejs#20315 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
Author
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Adjust indentations and fix a typo. PR-URL: #20315 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
If lines gets skipped, they are marked with three dots. This makes sure they are better visualized to distinguish them from everything else. PR-URL: #20315 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes