Closed
Conversation
nodejs-github-bot
added
test
richardlau
approved these changes
Apr 25, 2018
This comment has been minimized.
This comment has been minimized.
joyeecheung
approved these changes
Apr 25, 2018
2 tasks
Member
Author
BridgeAR
added
the
author ready
mmarchini
approved these changes
Apr 26, 2018
Member
trivikr
approved these changes
Apr 26, 2018
jasnell
approved these changes
Apr 27, 2018
refack
suggested changes
Apr 27, 2018
tools/test.py
Outdated
| self.severity = 'crashed' | ||
| exit_code = output.output.exit_code | ||
| self.traceback = "oh no!\nexit code: " + PrintCrashed(exit_code) | ||
| self.traceback += "oh no!\nexit code: " + PrintCrashed(exit_code) |
Contributor
There was a problem hiding this comment.
IMHO best solution is to drop this whole line and the prev line.
- L290 will set the exit code (it's new code)
- L300 will indicate crash
Member
Author
There was a problem hiding this comment.
I disagree because the exit code would not be visible in that case anymore. You are right.
Member
Author
|
Comment addressed. |
addaleax
removed
the
fast-track
Member
|
CI has only known flakes :) @refack Does this LGTY? |
Member
|
Landed in a4b4854 |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2018
PR-URL: #20295 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20295 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #20295 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nodejs/build PTAL
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes