Skip to content

doc: fix unhandled to uncaught#20293

Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:fix-wording-uncaught
Closed

doc: fix unhandled to uncaught#20293
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:fix-wording-uncaught

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Apr 25, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Apr 25, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 25, 2018

CI https://ci.nodejs.org/job/node-test-pull-request-lite/585/

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 25, 2018

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 26, 2018

Landed in bda2eaf

@BridgeAR BridgeAR closed this Apr 26, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 26, 2018
@BridgeAR
doc: fix unhandled to uncaught
bda2eaf 
PR-URL: nodejs#20293
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@BridgeAR @MylesBorins
doc: fix unhandled to uncaught
c139d2a 
PR-URL: #20293
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
@BridgeAR BridgeAR deleted the fix-wording-uncaught branch January 20, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@trivikr trivikr trivikr approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BridgeAR @vsemozhetbyt @lpinca @richardlau @trivikr @nodejs-github-bot