n-api,test: make method static#20292
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
One non-static method remains
nodejs-github-bot
added
dont-land-on-v4.x
node-api
cjihrig
approved these changes
Apr 25, 2018
Contributor
Author
Contributor
Author
|
The failing tests are flakes. |
BridgeAR
added
author ready
trivikr
approved these changes
Apr 26, 2018
Contributor
Author
|
Landed in 5a10d14. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 26, 2018
One non-static method remains PR-URL: nodejs#20292 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
One non-static method remains PR-URL: #20292 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One non-static method remains
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesWhoops! I left one out of the previous PR. Sorry!