http: refactor outgoing headers processing#20250
Closed
apapirovski wants to merge 2 commits intonodejs:masterfrom
Closed
http: refactor outgoing headers processing#20250apapirovski wants to merge 2 commits intonodejs:masterfrom
apapirovski wants to merge 2 commits intonodejs:masterfrom
Conversation
Use a shared function, for..in instead of Object.keys, do less work in `setHeader` and instead defer some of it until later, and other minor changes to improve clarity, as well as a slight boost in performance.
Contributor
Author
024c5a3 to
d909785
Compare
d909785 to
e21e7ff
Compare
Contributor
Author
|
Benchmarks: |
lpinca
approved these changes
Apr 24, 2018
trivikr
approved these changes
Apr 25, 2018
Member
|
CI rerun for node-test-commit-osx https://ci.nodejs.org/job/node-test-commit-osx/18148/ |
jasnell
approved these changes
Apr 27, 2018
Member
|
Landed in 602ffd6 |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2018
Use a shared function, for..in instead of Object.keys, do less work in `setHeader` and instead defer some of it until later, and other minor changes to improve clarity, as well as a slight boost in performance. PR-URL: #20250 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Use a shared function, for..in instead of Object.keys, do less work in `setHeader` and instead defer some of it until later, and other minor changes to improve clarity, as well as a slight boost in performance. PR-URL: #20250 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a shared function, for..in instead of Object.keys, do less work in
setHeaderand instead defer some of it until later, and other minorchanges to improve clarity, as well as a slight boost in performance.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes