n-api,test: make methods static#20243
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
gabrielschulhof
added
test
gabrielschulhof
force-pushed
the
n-api-make-static
branch
from
b6fb1bc to
34081ab
Compare
gabrielschulhof
added
dont-land-on-v4.x
and removed
tools
cjihrig
approved these changes
Apr 24, 2018
trivikr
approved these changes
Apr 24, 2018
BridgeAR
added
the
author ready
Contributor
Author
|
Landed in b699264. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 25, 2018
PR-URL: #20243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes