src: prefer false instead of bool zero#20218
Closed
danbev wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
This commit updates node_crypto.cc VerifySpkac function to use false instead of 0 for its return bool value i.
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 23, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
While you’re at it … it’s not really obvious what i might mean in this context, tbh.
Contributor
Author
Yeah, I was thinking the same thing. |
This commit renames the verification result variable, that is currently named i, to verify_result.
addaleax
approved these changes
Apr 23, 2018
addaleax
added
fast-track
Member
|
CI: https://ci.nodejs.org/job/node-test-commit/17944/ Please 👍 this comment if it’s okay to fast-track this. |
joyeecheung
approved these changes
Apr 23, 2018
richardlau
approved these changes
Apr 23, 2018
targos
approved these changes
Apr 23, 2018
JungMinu
approved these changes
Apr 23, 2018
cjihrig
approved these changes
Apr 23, 2018
jasnell
approved these changes
Apr 23, 2018
Member
|
Landed in e767aa1...c07c73c |
addaleax
removed
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Apr 23, 2018
This commit updates node_crypto.cc VerifySpkac function to use false instead of 0 for its return bool value i. PR-URL: #20218 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Apr 23, 2018
This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: #20218 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This commit updates node_crypto.cc VerifySpkac function to use false instead of 0 for its return bool value i. PR-URL: #20218 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: #20218 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates node_crypto.cc VerifySpkac function to use false
instead of 0 for its return bool value i.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes