src: cover extra load-via-special-symbol scenario#20186
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
src: cover extra load-via-special-symbol scenario#20186gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
We need to look for a special symbol even if the module self-registers when the module self-registers with the wrong version.
nodejs-github-bot
added
the
c++
bnoordhuis
approved these changes
Apr 21, 2018
joyeecheung
approved these changes
Apr 21, 2018
Member
BridgeAR
added
the
author ready
Contributor
Author
|
Landed in c1078c4. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 23, 2018
We need to look for a special symbol even if the module self-registers when the module self-registers with the wrong version. PR-URL: nodejs#20186 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
We need to look for a special symbol even if the module self-registers when the module self-registers with the wrong version. PR-URL: #20186 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRe #20161