doc: add tools/doc/README link in doc/STYLE_GUIDE#20071
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-link-doc-tools-readme
Closed
doc: add tools/doc/README link in doc/STYLE_GUIDE#20071vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-link-doc-tools-readme
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-link-doc-tools-readme
Conversation
vsemozhetbyt
added
doc
Contributor
Author
lpinca
approved these changes
Apr 16, 2018
BridgeAR
approved these changes
Apr 16, 2018
BridgeAR
added
the
author ready
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
Landed in addc04b |
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #20071 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #20047 (review)
This can be a temporal workaround till a possible major refactoring or merging so that this doc would not go off the radars.