doc: fix lint nits in COLLABORATOR_GUIDE.md#19762
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-collaborator-guide
Closed
doc: fix lint nits in COLLABORATOR_GUIDE.md#19762vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-collaborator-guide
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-collaborator-guide
Conversation
vsemozhetbyt
added
the
fast-track
Contributor
Author
2 tasks
Member
|
@nodejs/collaborators A second approval and +1 for fast-tracking this would let us unbreak CI... |
hybrist
approved these changes
Apr 2, 2018
Contributor
|
+1 for fast-tracking! |
Contributor
Author
|
Landing... |
Contributor
Author
|
Landed in 88773af. Thanks) |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 2, 2018
PR-URL: #19762 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 3, 2018
PR-URL: #19762 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesTo unbreak the doc linting)